commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-833) ToStringBuilder should use StringBuilder
Date Tue, 16 Oct 2012 08:57:03 GMT

    [ https://issues.apache.org/jira/browse/LANG-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476860#comment-13476860
] 

Sebb commented on LANG-833:
---------------------------

bq.  I believe lang3 allow breaking certain level of backward compatibility (and afaik it
did).

Releases of Lang must be binary compatible.
We did break binary compatibility when with Lang3, however that was done by changing package
name (and Maven coords) so code which still relies on the old API does not break. 
Code that wants to move to Lang3 has to be editted to use the new package name.
Further compat. breaks would require creating Lang4/changing package name again, so is not
to be undertaken lightly.

bq. declare buffer as AbstractStringBuilder instead

Have you tried this?
AbstractStringBuilder is package-protected, so cannot be used outside the JVM.

If you can provide a patch that solves the issue without breaking binary compatibility, please
attach it to this issue.
                
> ToStringBuilder should use StringBuilder
> ----------------------------------------
>
>                 Key: LANG-833
>                 URL: https://issues.apache.org/jira/browse/LANG-833
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>    Affects Versions: 3.1
>            Reporter: Shevek
>
> Rewriting as lang3 but still using StringBuffer (synchronized) looks like a missed opportunity.
Please use StringBuilder.
> Suggest audit for uses of StringBuffer in lang3 overall. No cause for it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message