commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-816) Multivariate Normal Mixture Models
Date Wed, 24 Oct 2012 21:50:13 GMT

    [ https://issues.apache.org/jira/browse/MATH-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483627#comment-13483627
] 

Gilles commented on MATH-816:
-----------------------------

Change to "reseedRandomGenerator" method committed in revision 1401894.

I didn't understand why you created this "MixtureMultivariateRealDistributionTest.java" file
that basically discarded all the corrections I had brought into "MultivariateNormalMixtureModelDistributionTest"
(including the removal of obsoleted tests like the weights summing up to one). All that was
needed was the new list of samples (also committed in r1401894)...

If you want to add another unit test, please create a patch with respect to the latest version
of that file. Note that it is better to not have multiple assertions in the same test method;
when testing for several preconditions, separate test methods are cleaner, e.g. "testPrecondition1()",
"testPrecondition2()", etc (if no better names come to mind), and using the Junit4 annotation
mechanism to specify which exception must be triggered (cf. "MultivariateNormalMixtureModelDistributionTest").

                
> Multivariate Normal Mixture Models
> ----------------------------------
>
>                 Key: MATH-816
>                 URL: https://issues.apache.org/jira/browse/MATH-816
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Jared Becksfort
>            Priority: Minor
>             Fix For: 3.2
>
>         Attachments: MixtureMultivariateRealDistribution.java, MixtureMultivariateRealDistribution.java,
MixtureMultivariateRealDistribution.java.patch, MixtureMultivariateRealDistributionTest.java,
MultivariateNormalMixtureModelDistribution.java, MultivariateNormalMixtureModelDistributionTest.java
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> I will submit a class for Multivariate Normal Mixture Models.  Not sure it will allow
sampling initially.
> > Hello,
> >
> > I have implemented some classes for multivariate Normal distributions, multivariate
normal mixture models, and an expectation maximization fitting class for the mixture model.
 I would like to submit it to Apache Commons Math.  I still have some touching up to do so
that they fit the style guidelines and implement the correct interfaces.  Before I do so,
I thought I would at least ask if the developers of the project are interested in me submitting
them.
> >
> > Thanks,
> > Jared Becksfort
> Dear Jared,
> Yes, that would be very nice to have such an addition! Remember to also include unit
tests (refer to the current ones for examples). The best would be to split a submission up
into multiple minor ones, each covering a natural submission (e.g. multivariate Normal distribution
in one submission), and create an issue as described at http://commons.apache.org/math/issue-tracking.html
.
> If you run into any problems, please do not hesitate to ask on this mailing list.
> Cheers, Mikkel.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message