commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Efthymis Sarbanis (JIRA)" <>
Subject [jira] [Updated] (LANG-795) Replace all "String encoding" parameters with Charset
Date Sun, 28 Oct 2012 22:27:12 GMT


Efthymis Sarbanis updated LANG-795:

    Attachment: LANG-795.test.patch

StringUtils.toString(byte[] bytes, String charsetName) cannot be overloaded. It will have
an ambiguity issue in case of a null charset.

A new method StringUtils.toEncodedString(byte[] bytes, String charset) should be introduced.

I have attached the relevant patches.
> Replace all "String encoding" parameters with Charset
> -----------------------------------------------------
>                 Key: LANG-795
>                 URL:
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.*
>    Affects Versions: 3.1
>            Reporter: Aaron Digulla
>         Attachments: LANG-795.patch, LANG-795.test.patch
> In several places, String constants are used to specify an encoding for data.
> Please add methods that accept {{Charset}} instead, and deprecate the existing methods.
> The goal of this change is to reduce code smell (using String constants instead of a
real value type).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message