Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Wed, 26 Sep 2012 20:16:08 +1100 (NCT)
From: "Gilles (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <955693795.127520.1348650968421.JavaMail.jiratomcat@arcas>
In-Reply-To: <662846381.2422.1341388714948.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (MATH-811) Improve event detection by selecting
 g function slope
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463644#comment-13463644 ] 

Gilles commented on MATH-811:
-----------------------------

bq. I think an enum with three choices (increasing, decreasing, both slope directions) is less confusing.

I think that it is more confusing; especially if we speak of "slope direction" (a slope cannot have _both_ directions).
If we really want to reduce the concept embodied in the enum to just "slope direction selection", it should be made clear in the name, e.g.:
{code}
public enum SlopeDirectionSelector {
    INCREASING,
    DECREASING,
    INCREASING_OR_DECREASING
}
{code}

Then the method "getSlopeSelection" should be renamed as
{code}
  SlopeDirectionSelector getSlopeDirectionSelector();
{code}

                
> Improve event detection by selecting g function slope
> -----------------------------------------------------
>
>                 Key: MATH-811
>                 URL: https://issues.apache.org/jira/browse/MATH-811
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.1
>            Reporter: Yannick TANGUY
>         Attachments: JIRA-811_slope_selection.patch, JIRA-811_slope_selection_with_spaces.patch
>
>
> We would like to select g function slope in CommonsMath event detection feature.
> This would improve event detection for the final user (the possibility to ignore some events, and less computation time) and also correct a bug found while using OREKIT (see https://www.orekit.org/forge/issues/104) in our applications. 
> The modification consists in adding a method (getSlopeSelection() : int) in EventHandler, and modifying one conditionnal in the method evaluateStep (class EventState). 
> We can provide modified code and unitary tests for this feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira