Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Fri, 21 Sep 2012 07:43:07 +1100 (NCT)
From: "Duncan Jones (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <2100308691.104632.1348173787850.JavaMail.jiratomcat@arcas>
In-Reply-To: 
 <1649631583.195.1323658470804.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Comment Edited] (CLI-224) OptionBuilder only has static
 methods, yet many return an OptionBuilder instance
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CLI-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459929#comment-13459929 ] 

Duncan Jones edited comment on CLI-224 at 9/21/12 7:42 AM:
-----------------------------------------------------------

Attached is an alternative patch (commons-cli-CLI-224.patch), based on my suggestion of a nested builder class. I must thank Brian for the design of the unit test, which I have used in my patch.

I welcome comments.
                
      was (Author: dmjones500):
    Attached is an alternative patch, based on my suggestion of a nested builder class. I must thank Brian for the design of the unit test, which I have used in my patch.

I welcome comments.
                  
> OptionBuilder only has static methods, yet many return an OptionBuilder instance
> --------------------------------------------------------------------------------
>
>                 Key: CLI-224
>                 URL: https://issues.apache.org/jira/browse/CLI-224
>             Project: Commons CLI
>          Issue Type: Bug
>          Components: CLI-1.x
>    Affects Versions: 1.2
>            Reporter: Brian Blount
>         Attachments: commons-cli-CLI-224.patch, DefaultOptionBuilder.java, DefaultOptionBuilderTest.java
>
>
> CLI-83 was closed as fixed in 2.0, but it seems that there is no current plan to release CLI 2.0.  Could this fix be rolled into the 1.x line?  I'm attaching a new version of option builder that addresses the issue (named DefaultOptionBuilder to maintain backwards compatability) and a unit test for it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira