Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 27 Sep 2012 13:07:07 +1100 (NCT)
From: "Sebb (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <1453899382.131699.1348711627989.JavaMail.jiratomcat@arcas>
In-Reply-To: <1003639687.129963.1348686308399.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (LANG-829) FastDateParser could use
 Calendar.getDisplayNames for all text fields
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LANG-829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464362#comment-13464362 ] 

Sebb commented on LANG-829:
---------------------------

bq. Also, the nameValues entries are only used by the TextStrategy, so could be saved in the instance.

This won't work, because the Strategy class instances are shared between formats.
Also, if the same field appears twice in a format, the nameValues approach would save memory.

However, dropping the KeyValue instances would simplify the code.
                
> FastDateParser could use Calendar.getDisplayNames for all text fields
> ---------------------------------------------------------------------
>
>                 Key: LANG-829
>                 URL: https://issues.apache.org/jira/browse/LANG-829
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.time.*
>            Reporter: Sebb
>            Priority: Minor
>
> FastDateParser could use Calendar.getDisplayNames for all text fields.
> This returns a map of names to indexes, which would be easier to search - no need to sort the symbols, and no need for the KeyValue instances.
> Also, the nameValues entries are only used by the TextStrategy, so could be saved in the instance.
> Overall this should reduce memory and be quicker.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira