commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christian Hammers (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CODEC-151) Remove unnecessary attempt to fill up the salt variable in UnixCrypt
Date Sat, 01 Sep 2012 16:02:08 GMT
Christian Hammers created CODEC-151:
---------------------------------------

             Summary: Remove unnecessary attempt to fill up the salt variable in UnixCrypt
                 Key: CODEC-151
                 URL: https://issues.apache.org/jira/browse/CODEC-151
             Project: Commons Codec
          Issue Type: Improvement
    Affects Versions: 1.6
            Reporter: Christian Hammers
            Priority: Minor
         Attachments: commons-codec-chammers-20120901-salt-noop.diff

https://github.com/lathspell/commons-codec/commit/878618cecb7b2f03550f0bb0e6642ca96187cbae

Note that the "// NOOP" comment was misleading, the salt variable
actually was modified inside the for loop.

This functionality will never be used though as the salt is checked
some lines above to an exact length of 2. Filling it with "A" would
be a very bad idea anyway as e.g. glibc fills a one-char salt with
exactly the same char so our implementation would have been incompatible!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message