commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yannick TANGUY (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MATH-811) Improve event detection by selecting g function slope
Date Mon, 24 Sep 2012 14:18:07 GMT

    [ https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461819#comment-13461819
] 

Yannick TANGUY edited comment on MATH-811 at 9/25/12 1:16 AM:
--------------------------------------------------------------

Ok, here is a patch and a simple unitary test (in EventStateTest.java).
EventHandler interface contains static values to distinguish wether we want to trigger incresing/decreasing
g function or both.
The method EventState.evaluateStep uses that value (getSlopeSelection).

Some unitary tests have been modified, so the implementation of EventState implement the new
getSlopeSelection (and returns EventHandler.INCREASING_DECREASING).

All comments are welcome ! If this patch is accepted, I will also prepare the "same" patch
for the OREKIT library.
                
      was (Author: ytanguy):
    Ok, here is a patch and a simple unitary test (in EventStateTest.java).
EventHandler interface contains static values to distinguish wether we want to trigger incresing/decreasing
g function or both.
The method EventState.evaluateStep uses that value (getSlopeSelection).

Some unitary tests have been modified, so the implementation of EventState implement the new
getSlopeSelection (and returns EventHandler.INCREASING_DECREASING).

All comments are welcome !
                  
> Improve event detection by selecting g function slope
> -----------------------------------------------------
>
>                 Key: MATH-811
>                 URL: https://issues.apache.org/jira/browse/MATH-811
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.1
>            Reporter: Yannick TANGUY
>         Attachments: JIRA-811_slope_selection.patch
>
>
> We would like to select g function slope in CommonsMath event detection feature.
> This would improve event detection for the final user (the possibility to ignore some
events, and less computation time) and also correct a bug found while using OREKIT (see https://www.orekit.org/forge/issues/104)
in our applications. 
> The modification consists in adding a method (getSlopeSelection() : int) in EventHandler,
and modifying one conditionnal in the method evaluateStep (class EventState). 
> We can provide modified code and unitary tests for this feature.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message