commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-863) new Quaternion class added in complex package
Date Wed, 19 Sep 2012 15:12:07 GMT

    [ https://issues.apache.org/jira/browse/MATH-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458743#comment-13458743
] 

Gilles commented on MATH-863:
-----------------------------

bq. double[] rather than Vector3D

Actually, I meant to use three "double"s; I'm sorry if I was not clear.
This would have the advantage that the dimension check is not necessary.

For the comparisons, you sometimes use 1e-14 and sometimes "Precision.EPSILON". If there is
a reason, it should probably be documented.
Maybe you can raise those issues on the "dev" ML.

To be consistent with what was done in the "Complex" class, I'd suggest to define only instance
methods (the "static" ones have no advantage here) and to rename "product" as "multiply".

                
> new Quaternion class added in complex package
> ---------------------------------------------
>
>                 Key: MATH-863
>                 URL: https://issues.apache.org/jira/browse/MATH-863
>             Project: Commons Math
>          Issue Type: New Feature
>    Affects Versions: 3.1
>            Reporter: Julien Anxionnat
>         Attachments: quaternion.patch, quaternion_v2.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> This patch provides a new class for the mathematical object "Quaternion" in the complex
package.
> This quaternion is considered as a mathematical object (the Hamilton's hypercomplex number).
> Note that it's not a rotation quaternion which has to be a quaternion of norm one. Although
this feature could be used for a getter in the Rotation class.
> This patch provides also some improvements in Precision class : a "double comparison
epsilon" and a method to compute relative comparison.
> (Please, note that's it's my first contribution, and I apologize in advance for my mistakes…)


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message