Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Fri, 17 Aug 2012 07:05:38 +1100 (NCT)
From: "Thomas Neidhart (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <81706986.20711.1345147538060.JavaMail.jiratomcat@arcas>
In-Reply-To: 
 <489636681.33951.1331126828152.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (COLLECTIONS-398) BoundedFifoBuffer could be
 simplified by keeping a count of the number of entries
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COLLECTIONS-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436275#comment-13436275 ] 

Thomas Neidhart commented on COLLECTIONS-398:
---------------------------------------------

The buffer implementations may be removed in favor of the Queue / Deque interfaces / implementation available in java.util.
                
> BoundedFifoBuffer could be simplified by keeping a count of the number of entries
> ---------------------------------------------------------------------------------
>
>                 Key: COLLECTIONS-398
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-398
>             Project: Commons Collections
>          Issue Type: Improvement
>            Reporter: Sebb
>         Attachments: COLLECTIONS-398-2.patch, COLLECTIONS-398.patch
>
>
> BoundedFifoBuffer could be much simplified by keeping a count of the number of entries, and dropping the boolean full.
> This would speed up size() and isEmpty() and isFull().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira