Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0E0CC915A for ; Thu, 2 Aug 2012 22:49:03 +0000 (UTC) Received: (qmail 72791 invoked by uid 500); 2 Aug 2012 22:49:02 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 72726 invoked by uid 500); 2 Aug 2012 22:49:02 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 72708 invoked by uid 99); 2 Aug 2012 22:49:02 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Aug 2012 22:49:02 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 68127142851 for ; Thu, 2 Aug 2012 22:49:02 +0000 (UTC) Date: Thu, 2 Aug 2012 22:49:02 +0000 (UTC) From: "Phil Steitz (JIRA)" To: issues@commons.apache.org Message-ID: <1953198620.7807.1343947742428.JavaMail.jiratomcat@issues-vm> In-Reply-To: <529938580.119049.1343692474480.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (MATH-834) Replace calls to the various sampling methods in "RandomDataImpl" MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MATH-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427691#comment-13427691 ] Phil Steitz commented on MATH-834: ---------------------------------- Are these changes really necessary? RandomData instances can be convenient. I was OK moving the implementations of the actual sampling methods to the distributions, but I see no reason that we should not keep RandomData as a means of generating random data from multiple different distributions. It is easier to just import one class and use nextXxx methods directly than to import and instantiate multiple distribution classes in use cases (e.g. AggregateSummaryStatisticsTest) where random data from different distributions are generated. > Replace calls to the various sampling methods in "RandomDataImpl" > ----------------------------------------------------------------- > > Key: MATH-834 > URL: https://issues.apache.org/jira/browse/MATH-834 > Project: Commons Math > Issue Type: Task > Reporter: Gilles > Assignee: Gilles > Priority: Minor > Fix For: 3.1 > > > Following MATH-764 and MATH-823, the "authoritative" code that implements sampling from distributions is located in the class that represents a specific distribution (in package "o.a.c.m.distribution"). > Hence, all CM code that performs sampling from a distribution should call the "sample" method from the corresponding distribution, instead of one of the methods defined in "RandomDataImpl" (in package "o.a.c.m.random"). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira