Return-Path: 
 <issues-return-29065-apmail-commons-issues-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-issues-archive@minotaur.apache.org
Delivered-To: apmail-commons-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 28C04DCD6
	for <apmail-commons-issues-archive@minotaur.apache.org>;
 Wed, 29 Aug 2012 15:18:08 +0000 (UTC)
Received: (qmail 50080 invoked by uid 500); 29 Aug 2012 15:18:07 -0000
Delivered-To: apmail-commons-issues-archive@commons.apache.org
Received: (qmail 50004 invoked by uid 500); 29 Aug 2012 15:18:07 -0000
Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@commons.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@commons.apache.org>
List-Post: <mailto:issues@commons.apache.org>
List-Id: <issues.commons.apache.org>
Reply-To: issues@commons.apache.org
Delivered-To: mailing list issues@commons.apache.org
Received: (qmail 49995 invoked by uid 99); 29 Aug 2012 15:18:07 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Aug 2012 15:18:07 +0000
Date: Thu, 30 Aug 2012 02:18:07 +1100 (NCT)
From: "Simone Tripodi (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <1579647489.12165.1346253487645.JavaMail.jiratomcat@arcas>
In-Reply-To: <1880723554.11591.1346245507801.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (DIGESTER-167) Groundless "Circular file
 inclusion detected" exception when including rules XML file
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/DIGESTER-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444129#comment-13444129 ] 

Simone Tripodi commented on DIGESTER-167:
-----------------------------------------

Good catch - any chance you can submit a patch (with testcase included)?

TIA!
                
> Groundless "Circular file inclusion detected" exception when including rules XML file
> -------------------------------------------------------------------------------------
>
>                 Key: DIGESTER-167
>                 URL: https://issues.apache.org/jira/browse/DIGESTER-167
>             Project: Commons Digester
>          Issue Type: Bug
>    Affects Versions: 3.2
>            Reporter: Eugene Fedotov
>
> Looks like org.apache.commons.digester3.xmlrules.IncludeRule doesn't remove the name of included XML rules resource from the set of included files of the memoryRulesBinder after included module is installed. Hence, one can include resource actually only once. Parsing  of the following XML rules (slightly modified example from the documentation) causes unexpected "Circular file inclusion detected" exception:
> rules1.xml
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
>         "-//Apache Commons //DTD digester-rules XML V1.0//EN"
>         "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
>     <pattern value="root/foo">
>         <object-create-rule classname="Foo"/>
>         <include url="classpath:/rules2.xml"/>
>     </pattern>
>     <pattern value="root/foo2">
>         <object-create-rule classname="Foo"/>
>         <include url="classpath:/rules2.xml"/>
>     </pattern>
> </digester-rules>
> rules2.xml
> <?xml version="1.0"?>
> <!DOCTYPE digester-rules PUBLIC
>         "-//Apache Commons //DTD digester-rules XML V1.0//EN"
>         "http://commons.apache.org/digester/dtds/digester-rules-3.0.dtd">
> <digester-rules>
>     <pattern value="bar">
>         <object-create-rule classname="Bar"/>
>     </pattern>
> </digester-rules>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira