commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-834) Replace calls to the various sampling methods in "RandomDataImpl"
Date Fri, 03 Aug 2012 11:55:02 GMT

    [ https://issues.apache.org/jira/browse/MATH-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428009#comment-13428009
] 

Gilles commented on MATH-834:
-----------------------------

bq. Are these changes really necessary?

No. I thought that it would be cleaner.
It may also open the possibility to reduce the number of methods in {{RandomDataImpl}}.

bq. RandomData instances can be convenient.

I agree but IMHO, {{RandomDataImpl}} does too many things (sampling from distributions, permutations,
secure RNG, secure string generation).
Maybe we could have the set of sampling utilities in a "DistributionsUtils" class, in package
"distribution".

                
> Replace calls to the various sampling methods in "RandomDataImpl"
> -----------------------------------------------------------------
>
>                 Key: MATH-834
>                 URL: https://issues.apache.org/jira/browse/MATH-834
>             Project: Commons Math
>          Issue Type: Task
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Minor
>             Fix For: 3.1
>
>
> Following MATH-764 and MATH-823, the "authoritative" code that implements sampling from
distributions is located in the class that represents a specific distribution (in package
"o.a.c.m.distribution").
> Hence, all CM code that performs sampling from a distribution should call the "sample"
method from the corresponding distribution, instead of one of the methods defined in "RandomDataImpl"
(in package "o.a.c.m.random").

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message