commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <>
Subject [jira] [Commented] (MATH-834) Replace calls to the various sampling methods in "RandomDataImpl"
Date Fri, 03 Aug 2012 11:55:02 GMT


Gilles commented on MATH-834:

bq. Are these changes really necessary?

No. I thought that it would be cleaner.
It may also open the possibility to reduce the number of methods in {{RandomDataImpl}}.

bq. RandomData instances can be convenient.

I agree but IMHO, {{RandomDataImpl}} does too many things (sampling from distributions, permutations,
secure RNG, secure string generation).
Maybe we could have the set of sampling utilities in a "DistributionsUtils" class, in package

> Replace calls to the various sampling methods in "RandomDataImpl"
> -----------------------------------------------------------------
>                 Key: MATH-834
>                 URL:
>             Project: Commons Math
>          Issue Type: Task
>            Reporter: Gilles
>            Assignee: Gilles
>            Priority: Minor
>             Fix For: 3.1
> Following MATH-764 and MATH-823, the "authoritative" code that implements sampling from
distributions is located in the class that represents a specific distribution (in package
> Hence, all CM code that performs sampling from a distribution should call the "sample"
method from the corresponding distribution, instead of one of the methods defined in "RandomDataImpl"
(in package "o.a.c.m.random").

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message