commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <>
Subject [jira] [Commented] (MATH-610) [patch] objects that use compareTo should have equals as well
Date Sat, 04 Aug 2012 16:49:02 GMT


Thomas Neidhart commented on MATH-610:

While Dave is spot-on with his observation, I think in this case it is not as severe as outlined
in the discussion. The private inner class IntDoublePair is not used in any public/protected
method and the equals method is never used for this class.

Otoh, the patch looks ok, so either we take it or just close this issue as Won't Fix.
> [patch] objects that use compareTo should have equals as well
> -------------------------------------------------------------
>                 Key: MATH-610
>                 URL:
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 3.1
>         Attachments: equals.diff
> NaturalRanking implements compareTo. Code that implements compareTo should also implement
equals, and those that implement equals should implement hashCode. This patch does this.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message