commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Clemens Novak (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-851) Add convolution
Date Thu, 23 Aug 2012 09:57:42 GMT

    [ https://issues.apache.org/jira/browse/MATH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440185#comment-13440185
] 

Clemens Novak commented on MATH-851:
------------------------------------

Ok - I'm a bit confused by now and hope you can help me better understanding the submission
process in this project.

* I write a patch / enhancement to existing project.

* I assume that the two of you (Gilles & S├ębastien) have SVN write access and would be
able to commit my changes.

* My code needs to follow some guidelines before my changes are accepted. When my code meets
these guidelines, then it will be submitted (given that the topic of the enhancement suits
the project; something that should have been checked in the beginning via the mailing list.
Anyway, guess we are already through this...).


Now this leaves some questions open:

* Who will the potential SVN submitter of the code I have written?

* It seems that there is some dissent about the rules -> Will the guy who will make the
submission also "enforce" his rules or do we need to find a consent before any more commits
are possible?

In one of the comments above you wrote that you are picky about source code formatting, Javadocs
etc... This is perfectly fine with me and I am willing to follow the rules. However, I think
we / you need to define the rules somewhere - I looked in the developers manual but this is
nowhere as detailed as the comments you gave me here. Above I proposed using the wiki, but
you told me that it is not used - Anyway, I don't care where the guidelines are, but the current
process of slowly "discovering" the rules one by one doesn't seem to be a very effective way
either (with the additional downside that the next contributor has to go through this process
as well).

Can we decide on the guidelines and fix them somewhere? This would make contributing for new
users much easier... If existing code doesn't follow the rules, it could be cleaned up over
time.

Please don't get me wrong - I'm the new guy here, don't know much about procedures and I'm
aware that there are some and I need to follow them. However, I'd like to contribute to this
library :-)
                
> Add convolution
> ---------------
>
>                 Key: MATH-851
>                 URL: https://issues.apache.org/jira/browse/MATH-851
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Clemens Novak
>            Priority: Minor
>         Attachments: Filter.java, FilterTest.java, FilterUtils.java, FilterUtils.java,
FilterUtilsTest.java, FilterUtilsTest.java
>
>
> I created a function performing (one-dimensional) convolution. Currently, the function
is in a class called Filter, but I am not sure whether this is the appropriate place for it(?).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message