Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Wed, 18 Jul 2012 21:03:34 +0000 (UTC)
From: "Thomas Neidhart (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <450047238.71670.1342645414424.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <720993619.12048.1314237689182.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MATH-651) eigendecompimpl allocates space for
 array imagEigenvalues when it is not needed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MATH-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417676#comment-13417676 ] 

Thomas Neidhart commented on MATH-651:
--------------------------------------

pushing to 4.0 as it would change the current behavior. As of version 3.1, also general asymmetric matrices are supported, thus there may be complex eigen values.

So the variable imagEigenvalues has some use now: it is used to distinguish between real and complex eigenvalues. In case of real eigenvalues, all entries are 0.
                
> eigendecompimpl allocates space for array imagEigenvalues when it is not needed
> -------------------------------------------------------------------------------
>
>                 Key: MATH-651
>                 URL: https://issues.apache.org/jira/browse/MATH-651
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.1
>         Environment: JAVA
>            Reporter: greg sterijevski
>            Assignee: Thomas Neidhart
>            Priority: Minor
>              Labels: EIGENDECOMPOSITIONIMPL
>             Fix For: 4.0
>
>         Attachments: eigendecompimpl
>
>
> The class variable imagEigenvalues is allocated even there is no use for it. I propose leaving the reference null. Patch will follow. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira