commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno P. Kinoshita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FUNCTOR-12) improve test coverage
Date Wed, 25 Jul 2012 01:02:34 GMT

    [ https://issues.apache.org/jira/browse/FUNCTOR-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421909#comment-13421909
] 

Bruno P. Kinoshita commented on FUNCTOR-12:
-------------------------------------------

Author: kinow
Date: Wed Jul 25 00:59:23 2012
New Revision: 1365377

URL: http://svn.apache.org/viewvc?rev=1365377&view=rev
Log:
[FUNCTOR-12] Added more tests for the adapter classes. Also removed unreachable code, as it
could not be tested and was immutable and created/validated during construction.

Some objects were immutable but could be null. In cases like this, no code was added, and
the null validation was left in place, i.e. no if's were removed. See FullyBoundFunction for
an example where the functor was validated, but the other arguments could be null, and in
equals() and hashcode() the validation wasn't removed.

Modified:
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/BinaryFunctionBinaryPredicate.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/BinaryFunctionBinaryProcedure.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/BinaryPredicateBinaryFunction.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/BinaryProcedureBinaryFunction.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/BoundPredicate.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/BoundProcedure.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/FullyBoundFunction.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/FullyBoundPredicate.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/FullyBoundProcedure.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/FunctionPredicate.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/FunctionProcedure.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/FunctionUnaryFunction.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/IgnoreLeftFunction.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/IgnoreLeftPredicate.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/IgnoreLeftProcedure.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/IgnoreRightFunction.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/IgnoreRightPredicate.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/IgnoreRightProcedure.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/LeftBoundFunction.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/LeftBoundPredicate.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/LeftBoundProcedure.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/PredicateFunction.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/PredicateUnaryPredicate.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/ProcedureFunction.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/ProcedureUnaryProcedure.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/RightBoundFunction.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/RightBoundPredicate.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/RightBoundProcedure.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/UnaryFunctionUnaryPredicate.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/UnaryFunctionUnaryProcedure.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/UnaryPredicateUnaryFunction.java
    commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/adapter/UnaryProcedureUnaryFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBinaryFunctionBinaryPredicate.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBinaryFunctionBinaryProcedure.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBinaryPredicateBinaryFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBinaryProcedureBinaryFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBinaryProcedureUnaryProcedure.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBoundFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBoundPredicate.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestBoundProcedure.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestFullyBoundFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestFullyBoundPredicate.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestFullyBoundProcedure.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestFunctionPredicate.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestFunctionProcedure.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestFunctionUnaryFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestIgnoreLeftFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestIgnoreLeftPredicate.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestIgnoreLeftProcedure.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestIgnoreRightFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestIgnoreRightPredicate.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestIgnoreRightProcedure.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestLeftBoundFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestLeftBoundPredicate.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestLeftBoundProcedure.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestPredicateFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestPredicateUnaryPredicate.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestProcedureFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestProcedureUnaryProcedure.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestRightBoundFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestRightBoundPredicate.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestRightBoundProcedure.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestUnaryFunctionUnaryPredicate.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestUnaryFunctionUnaryProcedure.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestUnaryPredicateUnaryFunction.java
    commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/adapter/TestUnaryProcedureUnaryFunction.java
                
> improve test coverage
> ---------------------
>
>                 Key: FUNCTOR-12
>                 URL: https://issues.apache.org/jira/browse/FUNCTOR-12
>             Project: Commons Functor
>          Issue Type: Improvement
>            Reporter: Emmanuel Bourg
>            Assignee: Bruno P. Kinoshita
>
> Specifically the composite package contains untested classes, per http://markmail.org/message/ythw55yad5lrvqrj

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message