commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sébastien Brisard (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MATH-795) Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
Date Sat, 07 Jul 2012 12:04:34 GMT

    [ https://issues.apache.org/jira/browse/MATH-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408644#comment-13408644
] 

Sébastien Brisard commented on MATH-795:
----------------------------------------

As of {{r1358547}}, refactoring should be complete. This refactring revealed some bugs, see
MATH-812.
                
> Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest
> ---------------------------------------------------------------------
>
>                 Key: MATH-795
>                 URL: https://issues.apache.org/jira/browse/MATH-795
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.1
>            Reporter: Sébastien Brisard
>            Assignee: Sébastien Brisard
>            Priority: Minor
>             Fix For: 3.1
>
>
> The above mentioned tests contain a lot of duplicate code. Besides, some of the unit
tests are no longer _unit_ tests, since they test many different functionalities.
> It is proposed to refactor these tests. The duplicate code should be factored out to
the abstract class {{RealVectorAbstractTest}}. Then some tests could be splitted in smaller
units.
> Besides readability, the benefit would be to ease the implementation of other kinds of
vector. This refactoring should also lead to a natural resolution of MATH-625.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message