commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-813) StringUtils.equalsIgnoreCase doesn't check string reference equality
Date Sat, 14 Jul 2012 00:50:36 GMT

    [ https://issues.apache.org/jira/browse/LANG-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414223#comment-13414223
] 

Sebb commented on LANG-813:
---------------------------

Another optimisation would be to check that the lengths are the same.
The code already calculates both lengths, so this would not add any overhead and would be
more efficient for sequences that differ only in length.
                
> StringUtils.equalsIgnoreCase doesn't check string reference equality
> --------------------------------------------------------------------
>
>                 Key: LANG-813
>                 URL: https://issues.apache.org/jira/browse/LANG-813
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>    Affects Versions: 3.1
>            Reporter: Paul Nepywoda
>
> This looks like a regression from .lang versions prior to 3. If the 2 given CharSequences
are strings (and both not null) you should check reference equality before delegating to regionMatches()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message