commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-822) Unnecessary Parameter in EigenDecomposition?
Date Sat, 14 Jul 2012 21:00:46 GMT

    [ https://issues.apache.org/jira/browse/MATH-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414499#comment-13414499
] 

Thomas Neidhart commented on MATH-822:
--------------------------------------

Hi Jared,

well spotted. I think your proposal makes sense. I will also mark the other constructors as
deprecated.

Thomas
                
> Unnecessary Parameter in EigenDecomposition?
> --------------------------------------------
>
>                 Key: MATH-822
>                 URL: https://issues.apache.org/jira/browse/MATH-822
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Jared Becksfort
>            Priority: Minor
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> I am still new to the Commons Math code base, so I am sorry if this is a dumb question.
 I am browsing the code for EigenDecomposition, and both of its constructors have an unused
parameter called splitTolerance.  The comments indicate that this is for backward compatibility.
> Would it be acceptable for me to simply include a one-parameter constructor that calls
the two-parameter one, so backward compatibility is preserved and client code no longer needs
to provide a pointless double?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message