commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (LOGGING-148) LogFactory.diagnosticPrefix and diagnosticsStream could be final
Date Wed, 18 Jul 2012 23:49:34 GMT

     [ https://issues.apache.org/jira/browse/LOGGING-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb resolved LOGGING-148.
--------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.2

Proved easier to inline part of the method and keep the rest.

URL: http://svn.apache.org/viewvc?rev=1363177&view=rev
Log:
LOGGING-148 - LogFactory.diagnosticPrefix and diagnosticsStream could be final

Modified:
    commons/proper/logging/trunk/RELEASE-NOTES.txt
    commons/proper/logging/trunk/src/java/org/apache/commons/logging/LogFactory.java
                
> LogFactory.diagnosticPrefix and diagnosticsStream could be final
> ----------------------------------------------------------------
>
>                 Key: LOGGING-148
>                 URL: https://issues.apache.org/jira/browse/LOGGING-148
>             Project: Commons Logging
>          Issue Type: Bug
>    Affects Versions: 1.1.1
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 1.1.2
>
>
> The static fields LogFactory.diagnosticPrefix and diagnosticsStream could be final.
> This would require inlining the code for the private method initDiagnostics() which is
only called from the static{} block.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message