commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary D. Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (VFS-405) Get/set the file permissions
Date Thu, 12 Jul 2012 19:27:34 GMT

    [ https://issues.apache.org/jira/browse/VFS-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413103#comment-13413103
] 

Gary D. Gregory commented on VFS-405:
-------------------------------------

We have two issues

(1) LocalProviderTestCase

This must be a difference between OSX and Windows. Who knows what happens on Linux, same as
OSX I would guess. 

I consider this a regression because an existing test ({{org.apache.commons.vfs2.provider.local.test.PermissionsTests}})
was removed and a new broken one ({{org.apache.commons.vfs2.test.PermissionsTests}}) was added.


I can see that the new test is not coded to test isExecutable() to account for Windows like
the old one was. 

Unless you can think of a better way to test isExecutable() in a platform neutral way, you
probably should leave the old test be, either in place or by using the same implementation
in the new class. 

I would go as far as strongly suggesting that the set and get APIs be tested in separate methods.
IOW, implement testIsExecutbale|R|W() and testSetExecutbale|R|W(). It's OK if the testSetExecutbale/Readable/Writable
tests use the is* APIs IMO, so you can do the set/get pattern I see in the patch.

(2) Testing with an embedded server.

I've taken great pains since 2.0 to have the tests run with embedded servers whenever possible
(I think WebDav is the remaining exception that's a TODO.) 

I would REALLY like to keep it that way. So, no, it's not fair to avoid testing (when 'mvn
test' is run) 

I sometimes spend more at work writing test code than production code for a feature, this
might be one of those cases. 

Maybe the test set up needs to be more elaborate...
                
> Get/set the file permissions
> ----------------------------
>
>                 Key: VFS-405
>                 URL: https://issues.apache.org/jira/browse/VFS-405
>             Project: Commons VFS
>          Issue Type: Improvement
>            Reporter: Damian Waszak
>         Attachments: permissions-0001.patch, permissions-0002.patch, permissions-0003.patch,
permissions-0004.patch, permissions-0005.patch
>
>
> Add possibility to change file permissions through VFS, similar to executing *chmod*
command on a file.
> Simple use case scenario would be to move a file to SFTP server, and then retrieve and
change the permissions, e.g. exececute chmod 0644.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message