commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Thomas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (POOL-226) GenericKeyedObjectPool.ObjectTimestampPair fields could be made final without breaking compat?
Date Tue, 31 Jul 2012 20:10:39 GMT

    [ https://issues.apache.org/jira/browse/POOL-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426080#comment-13426080
] 

Mark Thomas commented on POOL-226:
----------------------------------

That class is removed entirely in Pool2 anyway.

Personally, I am fine with making them private and final now.
                
> GenericKeyedObjectPool.ObjectTimestampPair fields could be made final without breaking
compat?
> ----------------------------------------------------------------------------------------------
>
>                 Key: POOL-226
>                 URL: https://issues.apache.org/jira/browse/POOL-226
>             Project: Commons Pool
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Minor
>
> The package protected static class GenericKeyedObjectPool.ObjectTimestampPair contains
two fields which are currently deprecated, pending making them final and private.
> Since the fields are package protected, surely they should only be used by Commons Pool
code? Does it make sense that any external code would use the fields? 
> Indeed can they be used?
> If the fields cannot legitimately be used by 3rd party code, then surely there's no need
to wait for a major release to change them?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message