commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-651) eigendecompimpl allocates space for array imagEigenvalues when it is not needed
Date Thu, 19 Jul 2012 06:28:34 GMT

    [ https://issues.apache.org/jira/browse/MATH-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418106#comment-13418106
] 

Thomas Neidhart commented on MATH-651:
--------------------------------------

That's right indeed. The reason I'd like to keep it open is to discuss how we want to distinguish
the case of real / complex eigenvalues. Right now, a user has to make a zero check on the
imagEigenvalues array to see if the result is maybe complex.

We could also solve it by adding a new method like "hasComplexEigenvalues" that does the trick.
                
> eigendecompimpl allocates space for array imagEigenvalues when it is not needed
> -------------------------------------------------------------------------------
>
>                 Key: MATH-651
>                 URL: https://issues.apache.org/jira/browse/MATH-651
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.1
>         Environment: JAVA
>            Reporter: greg sterijevski
>            Assignee: Thomas Neidhart
>            Priority: Minor
>              Labels: EIGENDECOMPOSITIONIMPL
>             Fix For: 4.0
>
>         Attachments: eigendecompimpl
>
>
> The class variable imagEigenvalues is allocated even there is no use for it. I propose
leaving the reference null. Patch will follow. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message