commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (LOGGING-147) SimpleLog.log - unsafe update of shortLogName
Date Wed, 18 Jul 2012 23:33:34 GMT

     [ https://issues.apache.org/jira/browse/LOGGING-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb resolved LOGGING-147.
--------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.2

Used temporary string to avoid possible update window.
Does not matter so much that the field is not volatile, as the worst that can happen is the
field is updated twice.

URL: http://svn.apache.org/viewvc?rev=1363173&view=rev
Log:
LOGGING-147 - SimpleLog.log - unsafe update of shortLogName

Modified:
    commons/proper/logging/trunk/RELEASE-NOTES.txt
    commons/proper/logging/trunk/src/java/org/apache/commons/logging/impl/SimpleLog.java

                
> SimpleLog.log - unsafe update of shortLogName
> ---------------------------------------------
>
>                 Key: LOGGING-147
>                 URL: https://issues.apache.org/jira/browse/LOGGING-147
>             Project: Commons Logging
>          Issue Type: Bug
>    Affects Versions: 1.1.1
>            Reporter: Sebb
>             Fix For: 1.1.2
>
>
> shortLogName is lazily updated, but:
> 1) field is not volatile, so is not safely published
> 2) fiels is written twice, so if log is called by two threads, one might get a partial
update.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message