Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 53F00988C for ; Mon, 25 Jun 2012 22:04:45 +0000 (UTC) Received: (qmail 23230 invoked by uid 500); 25 Jun 2012 22:04:45 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 23123 invoked by uid 500); 25 Jun 2012 22:04:44 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 23108 invoked by uid 99); 25 Jun 2012 22:04:44 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jun 2012 22:04:44 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 50838141BDA for ; Mon, 25 Jun 2012 22:04:44 +0000 (UTC) Date: Mon, 25 Jun 2012 22:04:44 +0000 (UTC) From: "Hudson (JIRA)" To: issues@commons.apache.org Message-ID: <1299401800.53662.1340661884333.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (COLLECTIONS-324) Fields transformer and decorated in comparators.TransformingComparator could be made final MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/COLLECTIONS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400951#comment-13400951 ] Hudson commented on COLLECTIONS-324: ------------------------------------ Integrated in commons-collections #45 (See [https://builds.apache.org/job/commons-collections/45/]) [COLLECTIONS-324] Made protected fields final to improve thread-safety. Thanks to sebb for the report. (Revision 1353172) Result = SUCCESS tn : http://svn.apache.org/viewvc/?view=rev&rev=1353172 Files : * /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/TransformingComparator.java > Fields transformer and decorated in comparators.TransformingComparator could be made final > ------------------------------------------------------------------------------------------ > > Key: COLLECTIONS-324 > URL: https://issues.apache.org/jira/browse/COLLECTIONS-324 > Project: Commons Collections > Issue Type: Improvement > Components: Comparator > Reporter: Sebb > Fix For: 4.0 > > > Fields transformer and decorated in comparators.TransformingComparator could be made final to improve thread-safety. > This will break subclasses that write to the fields, but would such code make any sense? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira