Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Fri, 15 Jun 2012 00:24:42 +0000 (UTC)
From: "Matt Whitlock (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: <1197254532.17423.1339719882457.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <1683057911.7788.1335729832217.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (OGNL-49) "Double-checked locking" anti-pattern
 in OgnlRuntime
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/OGNL-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295402#comment-13295402 ] 

Matt Whitlock commented on OGNL-49:
-----------------------------------

The patch was based on OGNL 3.0.5. Indeed there has been a significant reorganization in trunk since 3.0.5, so the patch no longer applies at all. Unfortunately, trunk still exhibits the double-checked locking anti-pattern. I'll submit another patch when I can get around to it.
                
> "Double-checked locking" anti-pattern in OgnlRuntime
> ----------------------------------------------------
>
>                 Key: OGNL-49
>                 URL: https://issues.apache.org/jira/browse/OGNL-49
>             Project: Commons OGNL
>          Issue Type: Bug
>         Environment: java version "1.6.0_31"
> Java(TM) SE Runtime Environment (build 1.6.0_31-b04)
> Java HotSpot(TM) 64-Bit Server VM (build 20.6-b01, mixed mode)
>            Reporter: Matt Whitlock
>            Assignee: Simone Tripodi
>            Priority: Critical
>         Attachments: 0001-ognl-avoid-double-checked-locking-anti-pattern-in-Og.patch
>
>
> OgnlRuntime in OGNL 3.0.5 has several occurrences of the "double-checked locking" anti-pattern. This has already manifested in our product in the form of:
> ognl.MethodFailedException: Method "xxx" failed for object yyy [java.lang.NoSuchMethodException: x.y.z.C.getFoo(java.lang.String)]
> But method x.y.z.C.getFoo(String) does exist, and in fact the same OGNL expression evaluates correctly when it is tried again subsequently.
> There are 11 occurrences of double-checked locking in OgnlRuntime that must be corrected. The simplest approach is to remove the unsynchronized accesses to the guarded structures. A better approach would be to use ReadWriteLocks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira