commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xavier Detant (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (EMAIL-118) smtpPort setter and getter doesn't works with the same type in EmailClass
Date Sun, 10 Jun 2012 13:54:42 GMT

    [ https://issues.apache.org/jira/browse/EMAIL-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292524#comment-13292524
] 

Xavier Detant edited comment on EMAIL-118 at 6/10/12 1:54 PM:
--------------------------------------------------------------

The patch to change smtp port from String to int. Maybe a method _public String getSmptPortAsString()_
should be usefull.
                
      was (Author: xadet):
    The patch to change smtp port from String to int.
                  
> smtpPort setter and getter doesn't works with the same type in EmailClass
> -------------------------------------------------------------------------
>
>                 Key: EMAIL-118
>                 URL: https://issues.apache.org/jira/browse/EMAIL-118
>             Project: Commons Email
>          Issue Type: Improvement
>    Affects Versions: 1.3
>            Reporter: Xavier Detant
>            Priority: Trivial
>              Labels: patch
>         Attachments: SmtpAsInt.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The smtpPort in the Email class can be set as an int but is get as a String. This is
quite bad design, the getter and the setter should works with the same type. As smtp ports
is a number, the getter which is currently _public String getSmtpPort()_ should be _public
int getSmtpPort()_:

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message