commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-805) RandomStringUtils.random(count, 0, 0, false, false, universe, random) always throws java.lang.ArrayIndexOutOfBoundsException
Date Sat, 09 Jun 2012 14:44:42 GMT

    [ https://issues.apache.org/jira/browse/LANG-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292356#comment-13292356
] 

Sebb commented on LANG-805:
---------------------------

bq. (Besides start is useless here)

I don't think start is useless; it should be possible to specify a subset of the char array.
                
> RandomStringUtils.random(count, 0, 0, false, false, universe, random) always throws java.lang.ArrayIndexOutOfBoundsException
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LANG-805
>                 URL: https://issues.apache.org/jira/browse/LANG-805
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.5, 2.6, 3.1
>            Reporter: Thomas BELOT
>            Priority: Blocker
>              Labels: patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> In commons-lang 2.6 line 250 :
> {code}ch = chars[random.nextInt(gap) + start];{code}
> This line of code takes a random int to fetch a char in the _chars_ array regardless
of its size.
> (Besides _start_ is useless here)
> Fixed version would be : 
> {code}ch = chars[random.nextInt(gap)%chars.length];{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message