commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcos Vinícius da Silva (JIRA) <j...@apache.org>
Subject [jira] [Updated] (IO-328) FileUtils.listFilesAndDirs includes originla dir in results even when it doesn't match filter
Date Tue, 05 Jun 2012 02:03:23 GMT

     [ https://issues.apache.org/jira/browse/IO-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Marcos Vinícius da Silva updated IO-328:
----------------------------------------

    Attachment: IO-328.patch

In this case, I think it makes more sense to not include the given directory, since the user
already knows it and it is beeing validated to be a directory at the beginning of the method.
                
> FileUtils.listFilesAndDirs includes originla dir in results even when it doesn't match
filter
> ---------------------------------------------------------------------------------------------
>
>                 Key: IO-328
>                 URL: https://issues.apache.org/jira/browse/IO-328
>             Project: Commons IO
>          Issue Type: Bug
>            Reporter: Hoss Man
>         Attachments: IO-328.patch, IO-328.testcase.patch
>
>
> listFilesAndDirs seems to always include the "directory" passed as input in it's resulting
Collection.  This is unexpected given the docs for the method...
> bq. Finds files within a given directory (and optionally its subdirectories). All files
found are filtered by an IOFileFilter. 
> * the "given directory" is not a subdirectory of itself
> * it is not subjected to the IOFileFilter dirFilter, it is always added.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message