commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SANDBOX-397) [BeanUtils2] Replace NullPointerExceptions been thrown in DefaultBeanAccessor with NoSuchMethodEceptions
Date Tue, 12 Jun 2012 18:59:43 GMT

    [ https://issues.apache.org/jira/browse/SANDBOX-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293845#comment-13293845
] 

Benedikt Ritter commented on SANDBOX-397:
-----------------------------------------

Hi Simo,

I'm very happy to hear, that you liked my idea. Many thanks for your improvements. Making
{{BeanProperties}} publicly available is a good idea. Here are some comments regarding your
commit:

* Usually I try to avoid long return statements like the ones introduced through {{checkMethod}}
in {{DefaultBeanProperties}}. To much inlining can be very confusing. However, since there
isn't to much logic in those methods, I guess we can leave it as it is.
* You should have a look at the extracted {{BeanProperties}} interface. I guess your IDE refactoring
created some public modifiers and some abstract method declarations, that we can get rid of.
* I'm not happy about those methods in {{BeanProperties}} either, but at the time I didn't
have a better solution. Feel free to change what ever you like (like you already did ;) )

regards,
Benedikt 
                
> [BeanUtils2] Replace NullPointerExceptions been thrown in DefaultBeanAccessor with NoSuchMethodEceptions
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SANDBOX-397
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-397
>             Project: Commons Sandbox
>          Issue Type: Task
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>            Assignee: Simone Tripodi
>         Attachments: SANDBOX-397.txt, SANDBOX-397_SRP.txt, SANDBOX-397_SRPv2.txt
>
>
> At the moment, methods in {{DefaultBeanAccessor}} throw a {{NullPointerException}}, if
no {{PropertyDescriptor}} for a given property name can be retrieved. As discussed on the
ML (see http://markmail.org/thread/zlehclmybp5xgn5n) this behavior should be changed to throwing
{{NoSuchMethodException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message