commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Farrukh Najmi (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SANSELAN-83) Rename src/test/data directory to src/test/resources to comply with maven conventions
Date Tue, 26 Jun 2012 21:04:43 GMT

     [ https://issues.apache.org/jira/browse/SANSELAN-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Farrukh Najmi updated SANSELAN-83:
----------------------------------

    Description: 
Currently established maven convention is not being following because test resources being
placed under src/test/data instead of src/test/resources directory. This causes problems is
maven-jar-plugin and possibly other situations. Proposed patch for SANSELAN-82 will not work
until the proposed fix for this issues is addressed.

The proposed fix is to rename src/test/data to src/test/resources and apply the following
patch to fix test code that setsup path for test data files:

{code}
Index: src/test/java/org/apache/commons/imaging/ImagingTestConstants.java
===================================================================
--- src/test/java/org/apache/commons/imaging/ImagingTestConstants.java  (revision 1354112)
+++ src/test/java/org/apache/commons/imaging/ImagingTestConstants.java  (working copy)
@@ -24,12 +24,12 @@
 
     static final File PHIL_HARVEY_TEST_IMAGE_FOLDER = new File(
             FilenameUtils
-                    .separatorsToSystem("src\\test\\data\\images\\exif\\philHarvey\\"));
+                    .separatorsToSystem("src\\test\\resources\\images\\exif\\philHarvey\\"));
 
     static final File SOURCE_FOLDER = new File("src");
     static final File TEST_SOURCE_FOLDER = new File(SOURCE_FOLDER, "test");
     static final File TEST_DATA_SOURCE_FOLDER = new File(TEST_SOURCE_FOLDER,
-            "data");
+            "resources");
     static final File TEST_IMAGE_FOLDER = new File(TEST_DATA_SOURCE_FOLDER,
             "images");
 }
{code}

  was:
Currently established maven convention is not being following because test resources being
placed under src/test/data instead of src/test/resources directory. This causes problems is
maven-jar-plugin and possibly other situations. 

The proposed fix is to rename src/test/data to src/test/resources and apply the following
patch to fix test code that setsup path for test data files:

{code}
Index: src/test/java/org/apache/commons/imaging/ImagingTestConstants.java
===================================================================
--- src/test/java/org/apache/commons/imaging/ImagingTestConstants.java  (revision 1354112)
+++ src/test/java/org/apache/commons/imaging/ImagingTestConstants.java  (working copy)
@@ -24,12 +24,12 @@
 
     static final File PHIL_HARVEY_TEST_IMAGE_FOLDER = new File(
             FilenameUtils
-                    .separatorsToSystem("src\\test\\data\\images\\exif\\philHarvey\\"));
+                    .separatorsToSystem("src\\test\\resources\\images\\exif\\philHarvey\\"));
 
     static final File SOURCE_FOLDER = new File("src");
     static final File TEST_SOURCE_FOLDER = new File(SOURCE_FOLDER, "test");
     static final File TEST_DATA_SOURCE_FOLDER = new File(TEST_SOURCE_FOLDER,
-            "data");
+            "resources");
     static final File TEST_IMAGE_FOLDER = new File(TEST_DATA_SOURCE_FOLDER,
             "images");
 }
{code}

    
> Rename src/test/data directory to src/test/resources to comply with maven conventions
> -------------------------------------------------------------------------------------
>
>                 Key: SANSELAN-83
>                 URL: https://issues.apache.org/jira/browse/SANSELAN-83
>             Project: Commons Sanselan
>          Issue Type: Improvement
>            Reporter: Farrukh Najmi
>         Attachments: SANSELAN-83-patch.txt
>
>
> Currently established maven convention is not being following because test resources
being placed under src/test/data instead of src/test/resources directory. This causes problems
is maven-jar-plugin and possibly other situations. Proposed patch for SANSELAN-82 will not
work until the proposed fix for this issues is addressed.
> The proposed fix is to rename src/test/data to src/test/resources and apply the following
patch to fix test code that setsup path for test data files:
> {code}
> Index: src/test/java/org/apache/commons/imaging/ImagingTestConstants.java
> ===================================================================
> --- src/test/java/org/apache/commons/imaging/ImagingTestConstants.java  (revision 1354112)
> +++ src/test/java/org/apache/commons/imaging/ImagingTestConstants.java  (working copy)
> @@ -24,12 +24,12 @@
>  
>      static final File PHIL_HARVEY_TEST_IMAGE_FOLDER = new File(
>              FilenameUtils
> -                    .separatorsToSystem("src\\test\\data\\images\\exif\\philHarvey\\"));
> +                    .separatorsToSystem("src\\test\\resources\\images\\exif\\philHarvey\\"));
>  
>      static final File SOURCE_FOLDER = new File("src");
>      static final File TEST_SOURCE_FOLDER = new File(SOURCE_FOLDER, "test");
>      static final File TEST_DATA_SOURCE_FOLDER = new File(TEST_SOURCE_FOLDER,
> -            "data");
> +            "resources");
>      static final File TEST_IMAGE_FOLDER = new File(TEST_DATA_SOURCE_FOLDER,
>              "images");
>  }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message