commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SANDBOX-419) [BeanUtils2] Implement setIndexed(String propertyName) on DefaultBeanAccessor
Date Tue, 12 Jun 2012 20:57:42 GMT

     [ https://issues.apache.org/jira/browse/SANDBOX-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Benedikt Ritter updated SANDBOX-419:
------------------------------------

    Attachment: SANDBOX-419.patch

I've created a patch for this issue. Summary:

* Changed {{DefaultIndexedPropertySetter}} to implement {{IndexedPropertySetterAccessor}}
(rather than {{IndexedPropertyGetterAccessor}})
* Created a new implementation of {{BeanPropertySetter}} for indexed porperties.

However this patch only servers for the purpose of discussion, since I'm unsure about two
issues:
# name of the new {{BeanPropertySetter}} implementation: Maybe it should be changed to "IndexedBeanPropertySetter"
to make it clear that it is variant of DefaultBeanPropertySetter
# checking of parameter types of the indexed setter method in {{IndexedPropertySetter}}:
#* can we be sure that the first parameter type always will be of type int and the second
parameter type will be the type of the indexed property?
#* if so do we have to check if the first parameter is really of type int or do we only have
to check if the second parameter type is assignment compatible to value?

After we have agreed on this points I can create a new patch (or you can simply modify the
patch).
                
> [BeanUtils2] Implement setIndexed(String propertyName) on DefaultBeanAccessor
> -----------------------------------------------------------------------------
>
>                 Key: SANDBOX-419
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-419
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>         Attachments: SANDBOX-419.patch
>
>
> Implement {{DefaultBeanAccessor.setIndexed(String propertyName)}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message