commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (JIRA)" <>
Subject [jira] [Commented] (SANDBOX-397) [BeanUtils2] Replace NullPointerExceptions been thrown in DefaultBeanAccessor with NoSuchMethodEceptions
Date Tue, 12 Jun 2012 19:46:42 GMT


Simone Tripodi commented on SANDBOX-397:

guten abend Bene,

Usually I try to avoid long return statements like the ones introduced through {{checkMethod}}
in {{DefaultBeanProperties}}. To much inlining can be very confusing. However, since there
isn't to much logic in those methods, I guess we can leave it as it is.

I am not sure I understood what you are referring - {{DefaultBeanProperties#checkMethod()}}
is similar to {{Assertions#checkNotNull}} but they throw different exceptions...

You should have a look at the extracted {{BeanProperties}} interface. I guess your IDE refactoring
created some public modifiers and some abstract method declarations, that we can get rid of.

hehehe yup perfectly right - I have been too lazy this time, thanks for pointing!

I'm not happy about those methods in {{BeanProperties}} either, but at the time I didn't have
a better solution. Feel free to change what ever you like (like you already did ;) )

nice to hear we found anyway an agreement!!

looking forward to apply more patches from you, alles gute!
> [BeanUtils2] Replace NullPointerExceptions been thrown in DefaultBeanAccessor with NoSuchMethodEceptions
> --------------------------------------------------------------------------------------------------------
>                 Key: SANDBOX-397
>                 URL:
>             Project: Commons Sandbox
>          Issue Type: Task
>          Components: BeanUtils2
>    Affects Versions: Nightly Builds
>            Reporter: Benedikt Ritter
>            Assignee: Simone Tripodi
>         Attachments: SANDBOX-397.txt, SANDBOX-397_SRP.txt, SANDBOX-397_SRPv2.txt
> At the moment, methods in {{DefaultBeanAccessor}} throw a {{NullPointerException}}, if
no {{PropertyDescriptor}} for a given property name can be retrieved. As discussed on the
ML (see this behavior should be changed to throwing

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message