commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COLLECTIONS-324) Fields transformer and decorated in comparators.TransformingComparator could be made final
Date Mon, 25 Jun 2012 21:33:44 GMT

    [ https://issues.apache.org/jira/browse/COLLECTIONS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400921#comment-13400921
] 

Hudson commented on COLLECTIONS-324:
------------------------------------

Integrated in commons-collections #44 (See [https://builds.apache.org/job/commons-collections/44/])
    [COLLECTIONS-324] Made protected fields final to improve thread-safety. Thanks to sebb
for the report. (Revision 1353172)

     Result = FAILURE
tn : http://svn.apache.org/viewvc/?view=rev&rev=1353172
Files : 
* /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/TransformingComparator.java

                
> Fields transformer and decorated in comparators.TransformingComparator could be made
final
> ------------------------------------------------------------------------------------------
>
>                 Key: COLLECTIONS-324
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-324
>             Project: Commons Collections
>          Issue Type: Improvement
>          Components: Comparator
>            Reporter: Sebb
>             Fix For: 4.0
>
>
> Fields transformer and decorated in comparators.TransformingComparator could be made
final to improve thread-safety.
> This will break subclasses that write to the fields, but would such code make any sense?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message