commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-805) RandomStringUtils.random(count, 0, 0, false, false, universe, random) always throws java.lang.ArrayIndexOutOfBoundsException
Date Sat, 09 Jun 2012 16:57:42 GMT

    [ https://issues.apache.org/jira/browse/LANG-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292383#comment-13292383
] 

Sebb commented on LANG-805:
---------------------------

Just to clarify: the code was only fixed today (in both lang 2.x and lang 3.x) thanks to your
JIRA report.
However it was fixed (in SVN) just before your reworked fix was added.

The Maven artifact name change was necessary because lang3 is not fully binary compatible
with lang2
                
> RandomStringUtils.random(count, 0, 0, false, false, universe, random) always throws java.lang.ArrayIndexOutOfBoundsException
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LANG-805
>                 URL: https://issues.apache.org/jira/browse/LANG-805
>             Project: Commons Lang
>          Issue Type: Bug
>    Affects Versions: 2.5, 2.6, 3.1
>            Reporter: Thomas BELOT
>            Priority: Blocker
>              Labels: patch
>             Fix For: 3.2, 2.7
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> In commons-lang 2.6 line 250 :
> {code}ch = chars[random.nextInt(gap) + start];{code}
> -This line of code takes a random int to fetch a char in the _chars_ array regardless
of its size.-
> -(Besides _start_ is useless here)-
> -Fixed version would be :-
> {code}//ch = chars[random.nextInt(gap)%chars.length];{code}
> When user pass 0 as _end_ or when the array is not null but empty this line ends up with
an exception

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message