commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <>
Subject [jira] [Created] (IO-335) Tailer#readLines - incorrect CR handling
Date Thu, 07 Jun 2012 20:42:24 GMT
Sebb created IO-335:

             Summary: Tailer#readLines - incorrect CR handling
                 Key: IO-335
             Project: Commons IO
          Issue Type: Bug
            Reporter: Sebb

The readLines method checks for CR. If found, it is not stored immediately, but a flag is

If the next char is an LF, the buffer is passed to the listener without the CR.
As soon as the next non-LF (and non-CR) character is received, the saved CR is written to
the buffer.

The net result is that CR before LF migrates to the start of the next non-empty line, and
repeated CRs are collapsed. This is clearly wrong.

The original code (before IO-274) used RandomAccessFile#readLine() which returns on CR, LF
or CRLF.

It looks as though the intention was to retain this behaviour whilst not blocking.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message