commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas BELOT (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LANG-805) RandomStringUtils.random(count, 0, 0, false, false, universe, random) always throws java.lang.ArrayIndexOutOfBoundsException
Date Sat, 09 Jun 2012 13:47:42 GMT
Thomas BELOT created LANG-805:
---------------------------------

             Summary: RandomStringUtils.random(count, 0, 0, false, false, universe, random)
always throws java.lang.ArrayIndexOutOfBoundsException
                 Key: LANG-805
                 URL: https://issues.apache.org/jira/browse/LANG-805
             Project: Commons Lang
          Issue Type: Bug
    Affects Versions: 2.6, 2.5
            Reporter: Thomas BELOT
            Priority: Blocker


In commons-lang 2.6 line 250 :
{code}ch = chars[random.nextInt(gap) + start];{code}
This line of code takes a random int to fetch a char in the {code}char{code} array regardless
of it's size.
(Besides {code}start{code} is useless here)

Fixed version would be : 
{code}ch = chars[random.nextInt(gap)%chars.length];{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message