Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D921C982 for ; Fri, 25 May 2012 01:02:43 +0000 (UTC) Received: (qmail 96993 invoked by uid 500); 25 May 2012 01:02:43 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 96892 invoked by uid 500); 25 May 2012 01:02:42 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 96884 invoked by uid 99); 25 May 2012 01:02:42 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 May 2012 01:02:42 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id AFCC314280B for ; Fri, 25 May 2012 01:02:42 +0000 (UTC) Date: Fri, 25 May 2012 01:02:42 +0000 (UTC) From: =?utf-8?Q?S=C3=A9bastien_Brisard_=28JIRA=29?= To: issues@commons.apache.org Message-ID: <506682045.72.1337907762726.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1825151446.4192.1337625340915.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (MATH-791) GammaDistribution.getAlpha() and getBeta() are confusing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MATH-791?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D132828= 83#comment-13282883 ]=20 S=C3=A9bastien Brisard commented on MATH-791: ---------------------------------------- New accessors have been defined in {{r1342404}}. =20 > GammaDistribution.getAlpha() and getBeta() are confusing > -------------------------------------------------------- > > Key: MATH-791 > URL: https://issues.apache.org/jira/browse/MATH-791 > Project: Commons Math > Issue Type: Improvement > Affects Versions: 3.1, 4.0 > Reporter: S=C3=A9bastien Brisard > Assignee: S=C3=A9bastien Brisard > Priority: Minor > > As discussed on the mailing list > {quote} > Some methods in {{o.a.c.m3.distribution.GammaDistribution}} are ill-named= . Indeed, the class javadoc explicitly refers to the Wikipedia page. In thi= s page, the shape parameter is named alpha and the scale parameter is 1 / b= eta > (inverse of beta), while in the current implementation, the shape paramet= er is named alpha, and the scale parameter is named beta (not 1 / beta !!!)= . This might be confusing. Looking at other web pages, I see there is appar= ently no consensus on the naming of shape and scale > parameters. The problem lies with the accessors, which are > {{double getAlpha()}} > {{double getBeta()}} > I think these accessors can lead to confusion. I would therefore propose = to deprecate them, and replace them with > {{double getShape()}} > {{double getScale()}} > {quote} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira