Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 10 May 2012 19:54:52 +0000 (UTC)
From: "Thomas Vandahl (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <1375849353.51089.1336679692557.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1813251268.8099.1331652639879.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (JCS-94) LateralTCPService should implement
 getGroupKeys
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JCS-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272688#comment-13272688 ] 

Thomas Vandahl commented on JCS-94:
-----------------------------------

I have some problems with the patch:
* It does not apply to my code base (Rev 1329570) without modifications. Your revision is 1334033. Where did you check that one out?
* Shouldn't group names be Strings instead of Serializables?
* It uses mixed code style
                
> LateralTCPService should implement getGroupKeys
> -----------------------------------------------
>
>                 Key: JCS-94
>                 URL: https://issues.apache.org/jira/browse/JCS-94
>             Project: Commons JCS
>          Issue Type: Improvement
>          Components: TCP Lateral Cache
>    Affects Versions: jcs-1.3, jcs-1.4-dev
>            Reporter: Andrew Leamon
>         Attachments: jcs.tar.gz, jcsGroupKeys.patch
>
>
> Calling getGroupKeys on LateralTCPService throws new UnsupportedOperationException( "Groups not implemented." );

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira