From issues-return-27211-apmail-commons-issues-archive=commons.apache.org@commons.apache.org Thu May 31 05:54:24 2012 Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A6964C78C for ; Thu, 31 May 2012 05:54:24 +0000 (UTC) Received: (qmail 1321 invoked by uid 500); 31 May 2012 05:54:24 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 1135 invoked by uid 500); 31 May 2012 05:54:24 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 1088 invoked by uid 99); 31 May 2012 05:54:23 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 May 2012 05:54:23 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 22698140C2C for ; Thu, 31 May 2012 05:54:23 +0000 (UTC) Date: Thu, 31 May 2012 05:54:23 +0000 (UTC) From: =?utf-8?Q?S=C3=A9bastien_Brisard_=28JIRA=29?= To: issues@commons.apache.org Message-ID: <124196354.20550.1338443663143.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1232750982.20477.1338443063967.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (MATH-795) Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MATH-795?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D132863= 49#comment-13286349 ]=20 S=C3=A9bastien Brisard commented on MATH-795: ---------------------------------------- Factored out {{testDataInOut()}} in {{r1344571}}. =20 > Refactoring ArrayRealVectorTest, RealVectorTest, SparseRealVectorTest > --------------------------------------------------------------------- > > Key: MATH-795 > URL: https://issues.apache.org/jira/browse/MATH-795 > Project: Commons Math > Issue Type: Improvement > Affects Versions: 3.1 > Reporter: S=C3=A9bastien Brisard > Assignee: S=C3=A9bastien Brisard > Priority: Minor > Fix For: 3.1 > > > The above mentioned tests contain a lot of duplicate code. Besides, some = of the unit tests are no longer _unit_ tests, since they test many differen= t functionalities. > It is proposed to refactor these tests. The duplicate code should be fact= ored out to the abstract class {{RealVectorAbstractTest}}. Then some tests = could be splitted in smaller units. > Besides readability, the benefit would be to ease the implementation of o= ther kinds of vector. This refactoring should also lead to a natural resolu= tion of MATH-625. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira