commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <>
Subject [jira] [Commented] (MATH-759) ListUnivariateImpl does not always access windowSize using synch.
Date Sat, 05 May 2012 13:43:51 GMT


Thomas Neidhart commented on MATH-759:

Cleanup of the ListUnivariateImpl class in r1334421:

 * removed unnecessary synchronized keywords (unit tests are single-threaded)
 * get windowSize using getter instead of protected member (in preparation for MATH-760)
> ListUnivariateImpl does not always access windowSize using synch.
> -----------------------------------------------------------------
>                 Key: MATH-759
>                 URL:
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
> ListUnivariateImpl has two synch. methods:
> getWindowSize
> setWindowSize
> However, windowSize is frequently referenced elsewhere without synch.
> It's not clear why the methods need synch., but if there is a need, then windowSize should
always be read using synch.
> The code should use the super-class getter and setter.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message