commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Thomas (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (POOL-216) GenericKeyedObjectPool.ensureMinIdle(K) does not need to check getMinIdlePerKey()
Date Wed, 02 May 2012 09:29:00 GMT

     [ https://issues.apache.org/jira/browse/POOL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mark Thomas resolved POOL-216.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0

Thanks. Fixed.
                
> GenericKeyedObjectPool.ensureMinIdle(K) does not need to check getMinIdlePerKey()
> ---------------------------------------------------------------------------------
>
>                 Key: POOL-216
>                 URL: https://issues.apache.org/jira/browse/POOL-216
>             Project: Commons Pool
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 2.0
>
>
> The private method GenericKeyedObjectPool.ensureMinIdle(K) checks getMinIdlePerKey().
> However, when called by ensureMinIdle(void), this check has already been done.
> The private method is only otherwise called by preparePool(K), so the check could be
moved there.
> This would eliminate one extra check per key when executing the protected ensureMinIdle()
method.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message