commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Hendriks (JIRA)" <>
Subject [jira] [Commented] (MATH-764) New sample() API should accept RandomGenerator as parameter
Date Wed, 30 May 2012 14:12:23 GMT


Dennis Hendriks commented on MATH-764:

bq. I would personally be OK with refactoring to do this move, ensuring that distributions
(or at least the sampling methods) had configurable RandomGenerators.

Once again, the distributions already have random generators. But an alternative to having
the random generator supplied via the constructor could be to remove the randomData field
from the distributions altogether, and instead provide the random generator as argument to
the sample method.
> New sample() API should accept RandomGenerator as parameter
> -----------------------------------------------------------
>                 Key: MATH-764
>                 URL:
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Alex Bertram
>         Attachments: sampler-refactor.diff
>   Original Estimate: 48h
>  Remaining Estimate: 48h
> This may come to late as I know the 3.0 release is nearing completion, but I had some
concerns about the new sample() method on the math3 RealDistribution interface. 
> Specifically, there doesn't seem to be a way to supply a random generator to the sampler.
Perhaps it would be better to have a factory method on the RealDistribution interface that
accepted a RandomGenerator and returns an instance of some new interface, Sampler, which contains
the sample() methods. 
> That is:
> interface RealDistribution {
>     Sampler createSampler(RandomGenerator generator);
>     Sample createSampler(); // uses default RandomGenerator
> }
> interface Sampler {
>     double sample();
>     double[] sample(int sampleSize);
> }

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message