commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary D. Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (VFS-321) AbstractFileObject sometimes uses getFileSystem() and sometimes references "fs" field directly
Date Wed, 16 May 2012 17:41:10 GMT

     [ https://issues.apache.org/jira/browse/VFS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gary D. Gregory resolved VFS-321.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1

I changed to calls to use "fs" directly because fs is a private final instance variable, final
being the more important aspect IMO. 
Committed revision 1339279.
                
> AbstractFileObject sometimes uses getFileSystem() and sometimes references "fs" field
directly
> ----------------------------------------------------------------------------------------------
>
>                 Key: VFS-321
>                 URL: https://issues.apache.org/jira/browse/VFS-321
>             Project: Commons VFS
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 2.1
>
>
> AbstractFileObject sometimes uses getFileSystem() - which just returns fs - and sometimes
references the "fs" field directly.
> If there is a good reason why the getter should be used sometimes and not others, then
this ought to be documented.
> If not, then it would be better to standardize on using either the field or the getter,
depending on whether there is any reason to override the getter.
> [There don't appear to be any overrides currently].

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message