commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-760) DescriptiveStatistics.windowSize has a getter and setter, but is protected, so subclasses can bypass the validation check in the setter
Date Fri, 04 May 2012 22:07:49 GMT

    [ https://issues.apache.org/jira/browse/MATH-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268744#comment-13268744
] 

Thomas Neidhart commented on MATH-760:
--------------------------------------

+1 for the change, but it would break source/binary compatibility thus postponing to 4.0
                
> DescriptiveStatistics.windowSize has a getter and setter, but is protected, so subclasses
can bypass the validation check in the setter
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MATH-760
>                 URL: https://issues.apache.org/jira/browse/MATH-760
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Sebb
>
> DescriptiveStatistics.windowSize has a setter which does validation and maintains the
list if necessary.
> However the field is protected, so classes can ignore the setter.
> As it happens, this is exactly what the subclass ListUnivariateImpl.setWindowSize does.
> The field should be made private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message