Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 289A598FE for ; Wed, 25 Apr 2012 16:04:47 +0000 (UTC) Received: (qmail 31532 invoked by uid 500); 25 Apr 2012 16:04:46 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 31464 invoked by uid 500); 25 Apr 2012 16:04:46 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 31456 invoked by uid 99); 25 Apr 2012 16:04:46 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Apr 2012 16:04:46 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Apr 2012 16:04:43 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 701CD35F4F4 for ; Wed, 25 Apr 2012 16:04:22 +0000 (UTC) Date: Wed, 25 Apr 2012 16:04:22 +0000 (UTC) From: "Diego Rivera (JIRA)" To: issues@commons.apache.org Message-ID: <1976221794.880.1335369862461.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <461478699.54149.1326925479913.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (JCS-87) Migrate to build with Maven 3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JCS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Rivera updated JCS-87: ---------------------------- Attachment: pom-maven-3.generics.diff Updated DIFF patch to support maven 3 builds - tested, and works fine except unit tests don't pass (but this is a code issue, not a buildfile issue). Still, you should verify this to be working as intended prior to full integration. Cheers. > Migrate to build with Maven 3.0 > ------------------------------- > > Key: JCS-87 > URL: https://issues.apache.org/jira/browse/JCS-87 > Project: Commons JCS > Issue Type: Improvement > Affects Versions: jcs-1.3 > Reporter: Diego Rivera > Assignee: Thomas Vandahl > Attachments: pom-maven-3.diff, pom-maven-3.generics.diff, pom.xml > > Original Estimate: 72h > Remaining Estimate: 72h > > Evidently, the documentation clearly states that Maven 1.x is the only supported mechanism to build JCS. However, this is very dated and it wouldn't be a bad idea to update the build process to more modern/current standards. > I've tried to do this, and have run into a few snags wrt tests - I get many unit tests failures in what I expect should have been trivial tests: > Failed tests: testIndexedDiskCache4(org.apache.jcs.auxiliary.disk.indexed.IndexedDiskCacheSameRegionConcurrentUnitTest$4): expected: but was: > testIndexedDiskCache5(org.apache.jcs.auxiliary.disk.indexed.IndexedDiskCacheSameRegionConcurrentUnitTest$5): expected: but was: > testIndexedDiskCache1(org.apache.jcs.auxiliary.disk.indexed.IndexedDiskCacheNoMemoryUnitTest$1): expected: but was: > testIndexedDiskCache3(org.apache.jcs.auxiliary.disk.indexed.IndexedDiskCacheNoMemoryUnitTest$3): expected: but was: > testIndexedDiskCache2(org.apache.jcs.auxiliary.disk.indexed.IndexedDiskCacheNoMemoryUnitTest$2): expected: but was: > testBlockDiskCache1(org.apache.jcs.auxiliary.disk.block.BlockDiskCacheSameRegionConcurrentUnitTest$1): Wrong value for key [0:key] expected: but was: > testBlockDiskCache2(org.apache.jcs.auxiliary.disk.block.BlockDiskCacheSameRegionConcurrentUnitTest$2): Wrong value for key [1000:key] expected: but was: > testBlockDiskCache3(org.apache.jcs.auxiliary.disk.block.BlockDiskCacheSameRegionConcurrentUnitTest$3): Wrong value for key [2000:key] expected: but was: > testBlockDiskCache4(org.apache.jcs.auxiliary.disk.block.BlockDiskCacheSameRegionConcurrentUnitTest$4): Wrong value for key [2200:key] expected: but was: > testExpireInBackground(org.apache.jcs.auxiliary.disk.jdbc.JDBCDiskCacheShrinkUnitTest): Removed key should be null: 0:key > testSpoolEvent(org.apache.jcs.engine.control.event.SimpleEventHandlingUnitTest): The number of ELEMENT_EVENT_SPOOLED_DISK_AVAILABLE events [0] does not equal the number expected [20000] > testSpoolNoDiskEvent(org.apache.jcs.engine.control.event.SimpleEventHandlingUnitTest): The number of ELEMENT_EVENT_SPOOLED_DISK_NOT_AVAILABLE events [19002] does not equal the number expected. > testSpoolNotAllowedEvent(org.apache.jcs.engine.control.event.SimpleEventHandlingUnitTest): The number of ELEMENT_EVENT_SPOOLED_NOT_ALLOWED events [0] does not equal the number expected. > testSpoolNotAllowedEventOnItem(org.apache.jcs.engine.control.event.SimpleEventHandlingUnitTest): The number of ELEMENT_EVENT_SPOOLED_NOT_ALLOWED events [0] does not equal the number expected. > testUpdateConfig(org.apache.jcs.engine.control.CompositeCacheDiskUsageUnitTest): expected:<1> but was:<0> > testSystemPropertyUsage(org.apache.jcs.engine.SystemPropertyUsageUnitTest): System property value is not reflected expected:<1000> but was:<6789> > testLoadFromCCF(org.apache.jcs.engine.memory.mru.MRUMemoryCacheUnitTest): Cache name should have MRU in it. > testGetStatsThroughHub(org.apache.jcs.engine.memory.mru.MRUMemoryCacheUnitTest): Should have 200 puts > testDefaultConfigUndefinedPool(org.apache.jcs.utils.threadpool.ThreadPoolManagerUnitTest): expected:<150> but was:<151> > testNonExistentConfigFile(org.apache.jcs.utils.threadpool.ThreadPoolManagerUnitTest): expected:<150> but was:<151> > testWaitPolicyConfig(org.apache.jcs.utils.threadpool.ThreadPoolManagerUnitTest): Max is wrong expected:<150> but was:<11> > testNoBoundary(org.apache.jcs.utils.threadpool.ThreadPoolManagerUnitTest): Should have a linked queue and not a bounded buffer. > testSystemPropertyInValueDelimeter(org.apache.jcs.access.SystemPropetyUnitTest): We should have used the system property for the memory size expected:<1234> but was:<6789> > Tests in error: > test(org.apache.jcs.auxiliary.lateral.socket.tcp.LateralTCPFilterRemoveHashCodeUnitTest): Socket is null, cannot connect to localhost:1110 > testPutLocalPutRemoteGetBusyVerifyRemoved(org.apache.jcs.auxiliary.lateral.socket.tcp.LateralTCPIssueRemoveOnPutUnitTest): Socket is null, cannot connect to localhost:1110 > testStandardPut(org.apache.jcs.auxiliary.lateral.socket.tcp.LateralTCPIssueRemoveOnPutUnitTest): Socket is null, cannot connect to localhost:1110 > Clearly something needs to be started to listen on that port (the RMI server, maybe?). However, the build documentation makes no mention of this anywhere. Migrating to a newer build mechanism may not fix this (and other) issues, but it would help revise the build process and perhaps find more elegant and future-proof mechanisms to meet these testing requirements. > If you'd like help implementing this feature, I might be able to provide time and effort towards this goal if someone helps me understand the full build process top-to-bottom. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira