Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Fri, 13 Apr 2012 16:53:16 +0000 (UTC)
From: =?utf-8?Q?Arne_Pl=C3=B6se_=28Commented=29_=28JIRA=29?= <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <1224759864.22684.1334335996904.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <702338865.13894.1311317217730.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MATH-627) superfluously null check of
 SparseIterator.next()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MATH-627?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D132535=
36#comment-13253536 ]=20

Arne Pl=C3=B6se commented on MATH-627:
---------------------------------

Sorry for beeing sloppy...

If you look at ArrayRealVector you will find this construct:
{code}
            while (it.hasNext() && (e =3D it.next()) !=3D null) {...}
{code}           =20
the same can also be found in RealVector=20
               =20
> superfluously null check of SparseIterator.next()
> -------------------------------------------------
>
>                 Key: MATH-627
>                 URL: https://issues.apache.org/jira/browse/MATH-627
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Arne Pl=C3=B6se
>            Priority: Minor
>             Fix For: 3.1
>
>
> Looking at the implementation of SparseIterator in OpenMapRealVector.Open=
MapSparseIterator there is no chance that the entry return by next() is eve=
r null - so there is no need to chek this in nearly every loop?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira