commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DBCP-384) PoolingDriver.accessToUnderlyingConnectionAllowed is thread-hostile
Date Thu, 26 Apr 2012 22:58:49 GMT
Sebb created DBCP-384:
-------------------------

             Summary: PoolingDriver.accessToUnderlyingConnectionAllowed is thread-hostile
                 Key: DBCP-384
                 URL: https://issues.apache.org/jira/browse/DBCP-384
             Project: Commons Dbcp
          Issue Type: Bug
            Reporter: Sebb


The field PoolingDriver.accessToUnderlyingConnectionAllowed is static but mutable; this is
inherently thread-hostile.

It seems completely unnecessary for the field to be static; surely it could be an instance
variable?
Better yet, drop the setter/getter and make the field final, set by the ctor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message