commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary D. Gregory (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CODEC-139) DigestUtils: additional utility methods
Date Fri, 20 Apr 2012 14:14:40 GMT

    [ https://issues.apache.org/jira/browse/CODEC-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258270#comment-13258270
] 

Gary D. Gregory commented on CODEC-139:
---------------------------------------

Hello Sebastian:

Thank you for the patch.

A couple of issues before this can go further:

- No unit tests
- The Javadoc for the updateDigest methods do not match the code. The docs talk about updating
the digest but the code calls the digest method which does an update AND then completes the
digest computation. Which way do you really mean? Plain update? Update AND complete (aka digest)?
Unit tests would help define the user cases.

Thank you,
Gary
                
> DigestUtils: additional utility methods
> ---------------------------------------
>
>                 Key: CODEC-139
>                 URL: https://issues.apache.org/jira/browse/CODEC-139
>             Project: Commons Codec
>          Issue Type: Improvement
>            Reporter: Sebastien Dubois
>            Priority: Trivial
>              Labels: patch
>         Attachments: DigestUtils-patch.txt
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> I've slightly modified the DigestUtils class:
> - changed the visibility (protected --> public) of a few methods: these methods are
generally useful if one just wants to get a MessageDigest instance for a given algorithm
> - added two 'updateDigest' methods which can be used to add more data to digest to the
provided MessageDigest. The advantage for the one that accepts a String argument is that it
keeps the same logic as the rest of DigestUtils (uses getBytesUtf8). The second one which
accepts a byte array is there for consistency

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message